Skip to content

wip: attempt to simplify workflows handling #2571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 93 commits into from
Closed

wip: attempt to simplify workflows handling #2571

wants to merge 93 commits into from

Conversation

metacosm
Copy link
Collaborator

  • refactor: remove now unneeded NameSetter interface
  • refactor: simplify workflow handling
  • refactor: initial work to combine ManagedWorkflow and regular one

csviri and others added 30 commits November 6, 2024 09:14
@csviri @metacosm
chore: set version to 5.0.0-SNAPSHOT (#2200)
984062c 
Signed-off-by: Attila Mészáros <[email protected]>
@csviri @metacosm
improve: java version minimal 11, tested on 21 (#2207)
5ed04b8 
Signed-off-by: Attila Mészáros <[email protected]>
@csviri @metacosm
improve: remove deprecated EventFilter (#2208)
bfc39cf 
Signed-off-by: Attila Mészáros <[email protected]>
@csviri @metacosm
docs: 5.0 migration guide skeleton (#2210)
5ffab28 
Signed-off-by: Attila Mészáros <[email protected]>
@csviri @metacosm
improve: managed dependent reconciliation results not optional (#2212)
9c42b2a 
Signed-off-by: Attila Mészáros <[email protected]>
@csviri @metacosm
improve: remove deprecated RetryConfiguration (#2211)
4da8a06 
Signed-off-by: Attila Mészáros <[email protected]>
@csviri @metacosm
feat: JDK client is now the default (#2235)
d5f31c8 
Signed-off-by: Attila Mészáros <[email protected]>
@metacosm
fix: update SCM information (#2237)
9ecb2e0 
Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
@csviri @metacosm
feat: move name is directly to dependent resource (#2250)
ddac34c 
* feat: move name is directly to dependent resource

- use this name when throwing aggregate exception

Signed-off-by: Attila Mészáros <[email protected]>

* refactor to use a dedicated interface for setting the name

Signed-off-by: Attila Mészáros <[email protected]>

* refactor: add default implementation for name() (#2255)

Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>

---------

Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
Co-authored-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
@csviri @metacosm
format
990ae76 
Signed-off-by: Attila Mészáros <[email protected]>
@csviri @metacosm
fix: test after rebase on master (#2270)
2df90a6 
Signed-off-by: Attila Mészáros <[email protected]>
@csviri @metacosm
feat: use java 17 as baseline (#2271)
321e772 
Signed-off-by: Attila Mészáros <[email protected]>
@csviri @metacosm
improve: matcher always considers metadata (#2273)
9515baa 
Signed-off-by: Attila Mészáros <[email protected]>
@csviri @metacosm
feat: API to check if next reconciliation is imminent (#2272)
eaf8d21 
Signed-off-by: Attila Mészáros <[email protected]>
@csviri @metacosm
feat: Workflow extracted to a separate annotation (#2274)
d3c299b 
Signed-off-by: Attila Mészáros <[email protected]>
@csviri @metacosm
fix: pom properties cleanup (#2280)
ae5f198 
Signed-off-by: Attila Mészáros <[email protected]>
@csviri @metacosm
improve: remove EventSourceInitializer (#2257)
26d94a8 
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
Co-authored-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
@metacosm
refactor: make loadFromProperties private (#2287)
841a09c 
Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
@csviri @metacosm
feat: distinguish resources based on desired state (#2252)
5dd6e76 
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
@csviri @metacosm
feat: explicit workflow invocation (#2289)
25a6604 
Signed-off-by: Attila Mészáros <[email protected]>
@metacosm
feat: use ssa for status update by default from UpdateControl (#2278)
4dbecaa 
Signed-off-by: Chris Laprun <[email protected]>
@metacosm
refactor: make WorkflowSpec an interface (#2300)
6545826 
Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
@csviri @metacosm
improve: replace current formatting plugins with spotless plugin (#2302)
aefec71 
Signed-off-by: Attila Mészáros <[email protected]>
@metacosm
refactor: make ManagedWorkflowSupport public to be able to reuse it (#…
2efb33d 
…2308)

Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
@csviri @metacosm
fix: package fix leader election sample (#2303)
c5e65c2 
Signed-off-by: Attila Mészáros <[email protected]>
@csviri @metacosm
feat: remove resource discriminator (#2299)
b409b86 
Signed-off-by: Attila Mészáros <[email protected]>
@metacosm
refactor: remove deprecated getTerminationTimeoutSeconds and associat…
d2f8b51 
…ed (#2297)

Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
@csviri @metacosm
improve: additional logging to mysql schema e2e test (#2320)
e0b44d0 
Signed-off-by: Attila Mészáros <[email protected]>
@metacosm
feat: handle clustered resource on secondary to primary mapper init (#…
e84be1c 
…2321)

Fixes #2311

Overriding getPrimaryResourceType should allow to make things work even
in deeper hierarchies.

Signed-off-by: Chris Laprun <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
@csviri @metacosm
feat: using SSA for finalizer and primary patch (#2305)
a2b7a56 
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
csviri and others added 19 commits November 6, 2024 09:18
@csviri @metacosm
improve: cleaner throws Exception (#2527)
da84cd3 

Signed-off-by: Attila Mészáros <[email protected]>
@metacosm
feat: explicit node configuration in WorkflowBuilder (#2511)
a8d71f4 
* feat: explicit node configuration in WorkflowBuilder

Fixes #2284

Signed-off-by: Chris Laprun <[email protected]>

* refactor: rename more appropriately

Signed-off-by: Chris Laprun <[email protected]>

---------

Signed-off-by: Chris Laprun <[email protected]>
@csviri @metacosm
fix: cleanup after rebase on main
ae05db9 
Signed-off-by: Attila Mészáros <[email protected]>
@csviri @metacosm
feat: context getSecondary resource is activation condition aware (#2532
f5677fe 
)


Signed-off-by: Attila Mészáros <[email protected]>
@csviri @metacosm
feat: e2e test to demonstrate namespace deletion problem fix (#2528)
fdc38df 

Signed-off-by: Attila Mészáros <[email protected]>
@csviri @metacosm
docs: remove javadoc todos (#2541)
811051e 
Signed-off-by: Attila Mészáros <[email protected]>
@10000-ki @metacosm
feat: print diff resource as yaml (#2542)
706ef55
@csviri @metacosm
fix: integration test timeout issue (#2547)
278def8 
Signed-off-by: Attila Mészáros <[email protected]>
@csviri @metacosm
improve: naming target resource selector method (#2546)
9b093b6
@bachmanity1 @metacosm
feat: improve diff logging (#2544)
d0f1be5 
* imporve diff logging

Signed-off-by: bachmanity1 <[email protected]>

* compute diff only when actual doesn't match desired

Signed-off-by: bachmanity1 <[email protected]>

* slight improvements

Signed-off-by: bachmanity1 <[email protected]>

* increase context size

Signed-off-by: bachmanity1 <[email protected]>

* fix style

Signed-off-by: bachmanity1 <[email protected]>

* calculate diff only if debug is enabled

Signed-off-by: bachmanity1 <[email protected]>

* print actual resources when trace is enabled

Signed-off-by: bachmanity1 <[email protected]>

* use java-diff-utils

Signed-off-by: bachmanity1 <[email protected]>

* add unit tests

---------

Signed-off-by: bachmanity1 <[email protected]>
@metacosm
fix: race condition in workflow reconciler (#2549)
5f6620d 
Signed-off-by: Chris Laprun <[email protected]>
@metacosm
feat(ci): split integration tests execution by category (#2548)
c566c3c 
* feat(build): split ITs by category, parallel CRD generation

Also avoid generating CRDs when not needed by default, summarizes test
results.

* chore(deps): bump actions-setup-minikube to 2.13.0
* feat: default to use vertx client
* chore(ci): reduce tested combinations, only run client tests on baseapi
* fix: increase deletion timeout

---------

Signed-off-by: Chris Laprun <[email protected]>
@metacosm
refactor: rename method more appropriately (#2554)
379de6d 
Signed-off-by: Chris Laprun <[email protected]>
@csviri @metacosm
improve: workflow builder naming (#2559)
e13cce6
@metacosm
chore: adapt after rebase
b9481fe 
Signed-off-by: Chris Laprun <[email protected]>
@Donnerbart @metacosm
fix: infinite resource updates due to canonical format conversion of …
0efc6d3 
…resource requirements (#2565)

* refactor: clean up SSABasedGenericKubernetesResourceMatcher

Signed-off-by: David Sondermann <[email protected]>

* test: add missing tests for StatefulSet with VolumeClaimTemplates for SSABasedGenericKubernetesResourceMatcher

Signed-off-by: David Sondermann <[email protected]>

* fix: Fix infinite resource updates due to canonical format conversion of resource requirements

Signed-off-by: David Sondermann <[email protected]>

* test: Add test cases with init containers to ResourceRequirementsSanitizerTest

Signed-off-by: David Sondermann <[email protected]>

---------

Signed-off-by: David Sondermann <[email protected]>
Signed-off-by: Chris Laprun <[email protected]>
@metacosm
refactor: remove now unneeded NameSetter interface
998c8f4 
Signed-off-by: Chris Laprun <[email protected]>
@metacosm
refactor: simplify workflow handling
c2f4efc 
Signed-off-by: Chris Laprun <[email protected]>
@metacosm
refactor: initial work to combine ManagedWorkflow and regular one
15ec65b 
Signed-off-by: Chris Laprun <[email protected]>
@metacosm metacosm self-assigned this Nov 12, 2024
@metacosm metacosm requested review from csviri and xstefank November 12, 2024 14:57
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 12, 2024
@metacosm metacosm mentioned this pull request Nov 12, 2024
Closed
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 14, 2024
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metacosm
Copy link
Collaborator Author

While it could be interesting to share more code between managed and manual workflows, there also isn't a need for it from a user's point of view at this point, so shutting this effort down for now.

@metacosm metacosm closed this Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@csviri csviri Awaiting requested review from csviri

@xstefank xstefank Awaiting requested review from xstefank

Assignees

@metacosm metacosm

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@metacosm @openshift-merge-robot @csviri @10000-ki @matteriben @bachmanity1 @Donnerbart